Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider exposing the docker_registry option #384

Closed
eitansuez opened this issue May 28, 2023 · 3 comments · Fixed by #409
Closed

consider exposing the docker_registry option #384

eitansuez opened this issue May 28, 2023 · 3 comments · Fixed by #409
Labels
enhancement New feature or request

Comments

@eitansuez
Copy link

TL;DR

cloud functions v1 uses container registry by default. container registry is being deprecated in favor of artifact registry. the gcloud functions deploy command has an option --docker-registry to control that. i'd like to be able to set that flag from the github action deploy-cloud-functions

Detailed design

No response

Additional information

No response
@eitansuez eitansuez added the enhancement New feature or request label May 28, 2023
@eitansuez
Copy link
Author

scanning the source, it looks like this option is already supported, perhaps just not documented in the readme.

@alessandrofajr
Copy link

scanning the source, it looks like this option is already supported, perhaps just not documented in the readme.

sorry if it's a noob question: where in the YML file we should specify the option of docker-registry?

@eitansuez
Copy link
Author

i think i was referring to the documentation in the readme.

@sethvargo sethvargo mentioned this issue May 21, 2024
Merged
sethvargo added a commit that referenced this issue May 22, 2024
@sethvargo
Switch to gen2 API (#409)
a5b186d 
This PR moves everything to use the `v2` API and adopts the "GEN_2"
function type. This is a major breaking change that should be released
as v3. As per our support policy, we will support v2 and v3, with v2
receiving critical bug fixes. We will drop support for v1.

- Fixes
#304
- Closes
#384
(N/A in GEN_2)
- Fixes
#373
- Closes
#399
(Cloud Functions recommends against CI/CD systems controlling IAM
permissions)
- Closes
#9
(N/A)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to gen2 API google-github-actions/deploy-cloud-functions
2 participants
@eitansuez @alessandrofajr