Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the last layer in distributional critic optimized (jax implementation)? #301

Open
Jogima-cyber opened this issue May 26, 2023 · 1 comment

Comments

@Jogima-cyber
Copy link

Jogima-cyber commented May 26, 2023

Hi! I was wondering if the last layer in the distributional critic used in dmpo, for example, is optimized in the jax implementation, since it is instantiated in the call function and not in the init?
https://github.com/deepmind/acme/blob/98c4204b9be7f327035bf1dbef26aa820cc4c1ec/acme/jax/networks/distributional.py#L373-L414

@Jogima-cyber Jogima-cyber changed the title Is the last layer in distributional critic optimized? Is the last layer in distributional critic optimized (jax implementation)? May 27, 2023
@ethanluoyc
Copy link
Contributor

It should, to check, you can take a look at the params initialized. It's a common pattern to create hk.Module inside call. You can find other examples in the Haiku examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants