Fix aws default credentials #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt0x6F
reviewed
May 19, 2024
| @@ -40,10 +40,6 @@ func New(s3Conf *config.S3Config, timeout time.Duration, options ...func(*aws.Co | |||
| return nil, errors.E(op, err) | |||
| } | |||
|
|
|||
| // Remove anonymous credentials from the default config so that | |||
| // session.NewSession can auto-resolve credentials from role, profile, env etc. | |||
| awsConfig.Credentials = nil | |||
There was a problem hiding this comment.
Ah, this is interesting. I wonder if roles, profiles, and ENV settings will break now?
There was a problem hiding this comment.
Okay, I think I understand the problem. Line 38 should be using this
There was a problem hiding this comment.
Okay, nevermind - this clearly says that roles, profiles, env etc should be covered by LoadDefaultConfig
matt0x6F
approved these changes
May 19, 2024
| @@ -40,10 +40,6 @@ func New(s3Conf *config.S3Config, timeout time.Duration, options ...func(*aws.Co | |||
| return nil, errors.E(op, err) | |||
| } | |||
|
|
|||
| // Remove anonymous credentials from the default config so that | |||
| // session.NewSession can auto-resolve credentials from role, profile, env etc. | |||
| awsConfig.Credentials = nil | |||
There was a problem hiding this comment.
Okay, nevermind - this clearly says that roles, profiles, env etc should be covered by LoadDefaultConfig
|
@yongzhang have you tested the build of this branch in your own infrastructure to verify it works? |
yea I tested and confirmed it works, but actually I didn't get a chance to test this part. |
matt0x6F
pushed a commit
to gomods/athens-charts
that referenced
this pull request
Jun 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gomods/athens](https://togithub.com/gomods/athens) | patch | `v0.14.0` -> `v0.14.1` | --- ### Release Notes <details> <summary>gomods/athens (gomods/athens)</summary> ### [`v0.14.1`](https://togithub.com/gomods/athens/releases/tag/v0.14.1) [Compare Source](https://togithub.com/gomods/athens/compare/v0.14.0...v0.14.1) #### What's Changed - CI dependency updates in [gomods/athens#1962 - Fix for AWS default credentials by [@​yongzhang](https://togithub.com/yongzhang) in [gomods/athens#1963 - Fix for E2E test runs by [@​joeymhills](https://togithub.com/joeymhills) in [gomods/athens#1966 - Feature gcp/saver: Only return errors.KindAlreadyExists if all three exist by [@​dwbuiten](https://togithub.com/dwbuiten) in [gomods/athens#1957 - Fix to set correct content type and send only once by [@​matt0x6F](https://togithub.com/matt0x6F) in [gomods/athens#1965 #### New Contributors - [@​yongzhang](https://togithub.com/yongzhang) made their first contribution in [gomods/athens#1963 - [@​joeymhills](https://togithub.com/joeymhills) made their first contribution in [gomods/athens#1966 - [@​dwbuiten](https://togithub.com/dwbuiten) made their first contribution in [gomods/athens#1957 **Full Changelog**: gomods/athens@v0.14.0...v0.14.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/gomods/athens-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Unable to access s3 with default config in v0.14.0, but v0.13.x works very well.
How is the fix applied?
Mention briefly how you have applied the fix.
What GitHub issue(s) does this PR fix or close?
Fixes #1961