{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":23096959,"defaultBranch":"master","name":"go","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-08-19T04:33:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716572565.0","currentOid":""},"activityList":{"items":[{"before":"a2eae66c3010efc507afca9f1f53fb7cf4d5671c","after":"377646589d5fb0224014683e0d1f1db35e60c3ac","ref":"refs/heads/master","pushedAt":"2024-05-24T22:24:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"text/template: clarify error when too few or too many return values\n\nPrior to CL 561115, calling a function without any return values would\nprint \"function called with 0 args; should be 1 or 2\". Afterwards, the\nerror message became \"too many return values\".\n\nKeep the improvement of referring to return values rather than args,\nand bring back clarity about their actual and permitted numbers.\n\nChange-Id: I2c014e4633208cc7052fac265a995a8f2fe68151\nReviewed-on: https://go-review.googlesource.com/c/go/+/588355\nReviewed-by: Dmitri Shuralyov \nReviewed-by: Ian Lance Taylor \nAuto-Submit: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"text/template: clarify error when too few or too many return values"}},{"before":"c506f035d99153accf7a9b322c6596fc7652aea6","after":"a2eae66c3010efc507afca9f1f53fb7cf4d5671c","ref":"refs/heads/master","pushedAt":"2024-05-24T21:37:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"doc: add release notes for a couple minor tracing features\n\nFor #65614.\n\nChange-Id: I759bf671b8f84c5224798b0dfaee6b158fdcc95a\nReviewed-on: https://go-review.googlesource.com/c/go/+/587927\nReviewed-by: Carlos Amedee \nAuto-Submit: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"doc: add release notes for a couple minor tracing features"}},{"before":"b89f946c8814b3d984f06cd836c74ef95bc0b868","after":"c506f035d99153accf7a9b322c6596fc7652aea6","ref":"refs/heads/master","pushedAt":"2024-05-24T21:22:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"text/template: add detailed info for goodFunc check\n\ngoodFunc now returns a error describe the exact error it met.\nbuiltin call function can print the name of the callee function\nif the goodFunc check failed.\n\nFor input {{call .InvalidReturnCountFunc}}\n\nbefore:\n can't evaluate field InvalidReturnTypeFunc in type *template.T\nafter:\n invalid function signature for .InvalidReturnTypeFunc: second argument should be error; is bool\n\nChange-Id: I9aa53424ac9a2bffbdbeac889390f41218817575\nGitHub-Last-Rev: 7c1e0dbd08884a38d92a42530104884a9ca52b44\nGitHub-Pull-Request: golang/go#65509\nReviewed-on: https://go-review.googlesource.com/c/go/+/561115\nReviewed-by: Rob Pike \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nCommit-Queue: Ian Lance Taylor \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"text/template: add detailed info for goodFunc check"}},{"before":"22a80e78ea6d65cd0b0726b2907f31b884aeda93","after":"b89f946c8814b3d984f06cd836c74ef95bc0b868","ref":"refs/heads/master","pushedAt":"2024-05-24T21:15:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/trace: remove last references to internal/trace/v2\n\nThis change removes the last few references to internal/trace/v2.\nNotably, it shows up in the generators' imports, so they'll fail to run\ncurrently.\n\nChange-Id: Ibc5a9c1844634ea7620558e270ca3db9921ba56e\nReviewed-on: https://go-review.googlesource.com/c/go/+/587930\nAuto-Submit: Michael Knyszek \nReviewed-by: Carlos Amedee \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"internal/trace: remove last references to internal/trace/v2"}},{"before":"5c7d7745387f240dbbd31940dce8be2b3000c53d","after":"22a80e78ea6d65cd0b0726b2907f31b884aeda93","ref":"refs/heads/master","pushedAt":"2024-05-24T21:10:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"syscall: Setrlimit: always clean rlimitNofileCache\n\nSince the introduction of origRlimitNofileCache in CL 476097 the only way to\ndisable restoring RLIMIT_NOFILE before calling execve syscall\n(os.StartProcess etc) is this:\n\n\tvar r syscall.Rlimit\n\tsyscall.Getrlimit(syscall.RLIMIT_NOFILE, &r)\n\tsyscall.Setrlimit(syscall.RLIMIT_NOFILE, &r)\n\nThe problem is, this only works when setrlimit syscall succeeds, which\nis not possible in some scenarios.\n\nLet's assume that if a user calls syscall.Setrlimit, they\nunconditionally want to disable restoring the original rlimit.\n\nFor #66797.\n\nChange-Id: I20d0365df4bd6a5c3cc8c22b0c0db87a25b52746\nReviewed-on: https://go-review.googlesource.com/c/go/+/588076\nRun-TryBot: Kirill Kolyshkin \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor \nTryBot-Bypass: Ian Lance Taylor ","shortMessageHtmlLink":"syscall: Setrlimit: always clean rlimitNofileCache"}},{"before":"3c96ae08701dd3ed66e0f8a81a80e3336a4d9aae","after":"cb55d1a0c8e37c4e5c3c45dc6e8fed8d76a18b90","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-05-24T21:01:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/link: add runtime.text.N symbols to macho symbol table in dynlink mode\n\nIn dynamic linking mode (e.g. when using plugins) on darwin, the\nmarker symbols runtime.text and runtime.etext are added to Textp\nin an early stage, so when adding symbols to the symbol table we\ndon't need to explicitly add them. However, when splitting text\nsections, the runtime.text.N marker symbols for the addtional\nsections are not added to Textp. So we do need to add them\nexplicitly to the symbol table.\n\nUpdates #66993.\nFixes #67527.\n\nChange-Id: Ic718d03cd71fc0bfb931cff82640b1f4c53b89be\nReviewed-on: https://go-review.googlesource.com/c/go/+/586555\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh \n(cherry picked from commit 9a9dd72d5c2b2f808a0a7ef204e307bc1dbee78c)\nReviewed-on: https://go-review.googlesource.com/c/go/+/586081","shortMessageHtmlLink":"[release-branch.go1.22] cmd/link: add runtime.text.N symbols to macho…"}},{"before":"6b89e7dc5a8f6c86db6dbb72f756bd555e8552e0","after":"3c96ae08701dd3ed66e0f8a81a80e3336a4d9aae","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-05-24T21:00:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] runtime: update large object stats before freeSpan in sweep\n\nCurrently freeSpan is called before large object stats are updated when\nsweeping large objects. This means heapStats.inHeap might get subtracted\nbefore the large object is added to the largeFree field. The end result\nis that the /memory/classes/heap/unused:bytes metric, which subtracts\nlive objects (alloc-free) from inHeap may overflow.\n\nFix this by always updating the large object stats before calling\nfreeSpan.\n\nFor #67019.\nFixes #67188.\n\nChange-Id: Ib02bd8dcd1cf8cd1bc0110b6141e74f678c10445\nReviewed-on: https://go-review.googlesource.com/c/go/+/583380\nAuto-Submit: Michael Knyszek \nReviewed-by: Felix Geisendörfer \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt \n(cherry picked from commit 36d32f68f41561fb64677297e3733f5d5b866c2a)\nReviewed-on: https://go-review.googlesource.com/c/go/+/584339\nReviewed-by: Carlos Amedee ","shortMessageHtmlLink":"[release-branch.go1.22] runtime: update large object stats before fre…"}},{"before":"185457da9bf7b617565e05e4ba95d89095fe7613","after":"6b89e7dc5a8f6c86db6dbb72f756bd555e8552e0","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-05-24T20:53:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/compile: initialize posBaseMap correctly\n\nThe posBaseMap is used to identify a file's syntax tree node\ngiven a source position. The position is mapped to the file\nbase which is then used to look up the file node in posBaseMap.\n\nWhen posBaseMap is initialized, the file position base\nis not the file base if there's a line directive before\nthe package clause. This can happen in cgo-generated files,\nfor instance due to an import \"C\" declaration.\n\nIf the wrong file position base is used during initialization,\nlooking up a file given a position will not find the file.\n\nIf a version error occurs and the corresponding file is\nnot found, the old code panicked with a null pointer exception.\n\nMake sure to consistently initialize the posBaseMap by factoring\nout the code computing the file base from a given position.\n\nWhile at it, check for a nil file pointer. This should not happen\nanymore, but don't crash if it happens (at the cost of a slightly\nless informative error message).\n\nFixes #67460.\n\nChange-Id: I4a6af88699c32ad01fffce124b06bb7f9e06f43d\nReviewed-on: https://go-review.googlesource.com/c/go/+/586238\nReviewed-by: Robert Findley \nReviewed-by: Robert Griesemer \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Robert Griesemer \nReviewed-on: https://go-review.googlesource.com/c/go/+/586161","shortMessageHtmlLink":"[release-branch.go1.22] cmd/compile: initialize posBaseMap correctly"}},{"before":"6f5219571c5fde780573918ba334030f002ce00e","after":"54c4745d7ca6650c4fe31be980277c85f97004ce","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-05-24T20:53:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] runtime: update large object stats before freeSpan in sweep\n\nCurrently freeSpan is called before large object stats are updated when\nsweeping large objects. This means heapStats.inHeap might get subtracted\nbefore the large object is added to the largeFree field. The end result\nis that the /memory/classes/heap/unused:bytes metric, which subtracts\nlive objects (alloc-free) from inHeap may overflow.\n\nFix this by always updating the large object stats before calling\nfreeSpan.\n\nFor #67019.\nFixes #67187.\n\nChange-Id: Ib02bd8dcd1cf8cd1bc0110b6141e74f678c10445\nReviewed-on: https://go-review.googlesource.com/c/go/+/583380\nAuto-Submit: Michael Knyszek \nReviewed-by: Felix Geisendörfer \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt \n(cherry picked from commit 36d32f68f41561fb64677297e3733f5d5b866c2a)\nReviewed-on: https://go-review.googlesource.com/c/go/+/584337","shortMessageHtmlLink":"[release-branch.go1.21] runtime: update large object stats before fre…"}},{"before":"54efef99b2b9432c2eb6cd63a287a13d43b9bb7b","after":"5c7d7745387f240dbbd31940dce8be2b3000c53d","ref":"refs/heads/master","pushedAt":"2024-05-24T20:26:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link: propagate FromAssembly attribute when cloning symbols to external\n\nWhen a symbol is cloned to external (in order to edit it),\npropagate the FromAssembly attribute, so the linker knows it is\n(originally) an assembly symbol, and can treat it specially (e.g.\nfor stack maps).\n\nThis should fix the Linux/RISCV64 builder.\n\nChange-Id: Icc956bcc43b79f328983a60835b05fd50f22326a\nReviewed-on: https://go-review.googlesource.com/c/go/+/587926\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/link: propagate FromAssembly attribute when cloning symbols to ex…"}},{"before":"1c924572d07df9c267028a20ee8934a94bfd7f8c","after":"54efef99b2b9432c2eb6cd63a287a13d43b9bb7b","ref":"refs/heads/master","pushedAt":"2024-05-24T19:15:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"iter: deflake TestPull by letting exiting goroutines finish\n\nCurrently TestPull is flaky because goroutines spawned to run subtests\nexit asynchronously when they finish and TestPull has explicit checks\nfor the number of existing goroutines.\n\nThis is pretty much only a problem between subtests executing, because\nwithin each subtest the coroutine goroutine spawned for iter.Pull always\nexits fully synchronously before the final `next` or `stop` returns.\n\nSo, we can resolve the problem by ensuring the first goroutine count the\ntest takes likely doesn't contain any exiting goroutines. The trick is\nto set GOMAXPROCS=1 and spin in runtime.Gosched until the number of\ngoroutines stabilizes to some reasonable degree (we pick 100 consecutive\niterations; there are only a handful of possible goroutines that can\nrun, so this is giving that handful around 20 chances to actually run to\ncompletion).\n\nWhen running TestPull under stress2, this issue is easily reproducible\nbefore this CL. After this CL, it no longer reproduces under these\nconditions.\n\nFixes #66017.\n\nChange-Id: I4bf0a9771f7364df7dd58f8aeb3ae26742d5746f\nReviewed-on: https://go-review.googlesource.com/c/go/+/587917\nReviewed-by: David Chase \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"iter: deflake TestPull by letting exiting goroutines finish"}},{"before":"f5d6d8bfaa89bdd78c6244839c57b1beb1534452","after":null,"ref":"refs/heads/adonovan-patch-1","pushedAt":"2024-05-24T17:42:45.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"}},{"before":"7bc7039a6a518ed43f6177763d584e354ebd4bd7","after":"1c924572d07df9c267028a20ee8934a94bfd7f8c","ref":"refs/heads/master","pushedAt":"2024-05-24T17:16:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"runtime: fix the inconsistency of kq parameter of addWakeupEvent\n\nChange-Id: I4f1668ed9085cf19c3eff17c237601a91d0660db\nReviewed-on: https://go-review.googlesource.com/c/go/+/587876\nReviewed-by: Carlos Amedee \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor ","shortMessageHtmlLink":"runtime: fix the inconsistency of kq parameter of addWakeupEvent"}},{"before":"a7f6da78d2c022b44b8d91f3ce7699ab1643968f","after":"7bc7039a6a518ed43f6177763d584e354ebd4bd7","ref":"refs/heads/master","pushedAt":"2024-05-24T17:15:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"syscall: prevent redundant newline from empty $extraimports\n\nCurrently mksyscall script produces one redundant newline\nwhen $extraimports is empty, leading to a gofmt warning\nreported by \"git codereview change\".\n\nChange-Id: I57b0fa040347375698973e777285deded16ab62e\nReviewed-on: https://go-review.googlesource.com/c/go/+/587877\nReviewed-by: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Carlos Amedee \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"syscall: prevent redundant newline from empty $extraimports"}},{"before":"85115da5d3351c4300337579eafe726700f3b587","after":"a7f6da78d2c022b44b8d91f3ce7699ab1643968f","ref":"refs/heads/master","pushedAt":"2024-05-24T17:14:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go: env changed flag respects $GOROOT/go.env\n\nFrom $GOROOT/go.env file got GOPROXY and GOSUMDB and GOTOOLCHAIN default value.\n\nFixes #67542\n\nChange-Id: I0cb2e1ab6a32963288ae463a9b0bd92ac6719447\nGitHub-Last-Rev: fda9be48b9e3bd3b124648eec1ef4ecfccac6d50\nGitHub-Pull-Request: golang/go#67564\nReviewed-on: https://go-review.googlesource.com/c/go/+/587160\nReviewed-by: Carlos Amedee \nAuto-Submit: Michael Matloob \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Matloob ","shortMessageHtmlLink":"cmd/go: env changed flag respects $GOROOT/go.env"}},{"before":"60e69866121dffa686cfbc27aee32cd2f6dc05ca","after":"85115da5d3351c4300337579eafe726700f3b587","ref":"refs/heads/master","pushedAt":"2024-05-24T17:13:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"errors: change interface{} to any in comment\n\nChange-Id: Ibf28c4b3026019427a2485230e14929ed80a1727\nReviewed-on: https://go-review.googlesource.com/c/go/+/587255\nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Carlos Amedee ","shortMessageHtmlLink":"errors: change interface{} to any in comment"}},{"before":"960cd141248b3e61ab651038097523a02dfa427b","after":"60e69866121dffa686cfbc27aee32cd2f6dc05ca","ref":"refs/heads/master","pushedAt":"2024-05-24T17:09:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":".github/ISSUE_TEMPLATE/03-gopls.yml: use textarea for gopls version\n\nThe output of \"gopls version\" is multiple lines.\n\nChange-Id: Ic00734b05011098d408db6f49f86c4e2c8edfa24\nReviewed-on: https://go-review.googlesource.com/c/go/+/587924\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":".github/ISSUE_TEMPLATE/03-gopls.yml: use textarea for gopls version"}},{"before":"f85c40438fea862be03d2de4b58ed3afe7cfe033","after":"960cd141248b3e61ab651038097523a02dfa427b","ref":"refs/heads/master","pushedAt":"2024-05-24T16:43:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"doc/README: suggest a way to preview next content, tweak release steps\n\nSmaller edits are usually fine to do without previewing, since Markdown\ncan be intuitive. But for larger changes including re-ordering sections\nand such, it can be helpful to quickly see the end result. Write down a\nway to do that.\n\nUpdate the release steps to capture that the doc/next content will move\nto x/website before RC 1, when the complete release note draft is ready.\n\nFor #64169.\n\nChange-Id: Ie554ed5294ce819fd0689e2249e6013826f0c71f\nReviewed-on: https://go-review.googlesource.com/c/go/+/587922\nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Dmitri Shuralyov \nTryBot-Bypass: Dmitri Shuralyov \nReviewed-by: Jonathan Amsterdam ","shortMessageHtmlLink":"doc/README: suggest a way to preview next content, tweak release steps"}},{"before":"378c48df3b485da1ed287f59e5d1f59ad232e554","after":"f85c40438fea862be03d2de4b58ed3afe7cfe033","ref":"refs/heads/master","pushedAt":"2024-05-24T16:41:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/runtime/exithook: make safe for concurrent os.Exit\n\nReal programs can call os.Exit concurrently from multiple goroutines.\nMake internal/runtime/exithook not crash in that case.\n\nThe throw on panic also now runs in the deferred context,\nso that we will see the full stack trace that led to the panic.\nThat should give us more visibility into the flaky failures on\nbugs #55167 and #56197 as well.\n\nFixes #67631.\n\nChange-Id: Iefdf71b3a3b52a793ca88d89a9c270eb50ece094\nReviewed-on: https://go-review.googlesource.com/c/go/+/588235\nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Russ Cox ","shortMessageHtmlLink":"internal/runtime/exithook: make safe for concurrent os.Exit"}},{"before":null,"after":"f5d6d8bfaa89bdd78c6244839c57b1beb1534452","ref":"refs/heads/adonovan-patch-1","pushedAt":"2024-05-24T16:29:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"adonovan","name":"Alan Donovan","path":"/adonovan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5658175?s=80&v=4"},"commit":{"message":"Update 03-gopls.yml\n\nChange gopls version field to textarea","shortMessageHtmlLink":"Update 03-gopls.yml"}},{"before":"2785f4fad60a3cdee2edc1efbe860b8ccba519cc","after":"378c48df3b485da1ed287f59e5d1f59ad232e554","ref":"refs/heads/master","pushedAt":"2024-05-24T15:55:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go/internal/modload: fix bug in error message\n\nCL 513756 moved the usage of modGo after it was set to its proper value,\nso the error message text always listed the version of go as\n\"unspecified\". Fix the error message in the case where the version was\nset in the go.mod, and provide an error message where it wasn't.\n\nFixes #67587\n\nChange-Id: I763f6be7ee811da32fcb7e785682fd6f48145981\nReviewed-on: https://go-review.googlesource.com/c/go/+/588075\nReviewed-by: Sam Thanawalla \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/go/internal/modload: fix bug in error message"}},{"before":"3ea2be1e4786abd39bc1fbd429c936d9fb89ec00","after":"2785f4fad60a3cdee2edc1efbe860b8ccba519cc","ref":"refs/heads/master","pushedAt":"2024-05-24T15:45:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go/internal/telemetrystats: fix assignment to ok\n\nChange-Id: I7ee6198949bd2ea7e92d3e75c94ead04c31be491\nReviewed-on: https://go-review.googlesource.com/c/go/+/588236\nAuto-Submit: Michael Matloob \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"cmd/go/internal/telemetrystats: fix assignment to ok"}},{"before":"35ef4a9f330fdff870ff637558ec2fd03a93fd9c","after":"3ea2be1e4786abd39bc1fbd429c936d9fb89ec00","ref":"refs/heads/master","pushedAt":"2024-05-24T13:54:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/types, types2: pull up Unalias call to cover all of cycleFinder.typ\n\nWithout a test because it's unclear the situation can actually occur,\nbut the code is correct because it now mimics the behavior without\nexplicit Alias nodes.\n\nFor #67547.\n\nChange-Id: I21a31af28880ca6d599fe465563d9574c26ed1f1\nReviewed-on: https://go-review.googlesource.com/c/go/+/588117\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Griesemer \nAuto-Submit: Robert Griesemer \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"go/types, types2: pull up Unalias call to cover all of cycleFinder.typ"}},{"before":"2fe2e4d593aaa01ca00ad861808846a2b3328b05","after":"35ef4a9f330fdff870ff637558ec2fd03a93fd9c","ref":"refs/heads/master","pushedAt":"2024-05-24T03:44:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"runtime: x_cgo_getstackbound: initialize pthread attr\n\nIn glibc versions older than 2.32 (before commit 4721f95058),\npthread_getattr_np does not always initialize the `attr` argument,\nand when it fails, it results in a NULL pointer dereference in\npthread_attr_destroy down the road.\n\nThis is the simplest way to avoid this, and an alternative to CL 585019.\n\nUpdates #65625.\n\nChange-Id: If490fd37020b03eb084ebbdbf9ae0248916426d0\nReviewed-on: https://go-review.googlesource.com/c/go/+/587919\nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nReviewed-by: Cherry Mui \nTryBot-Result: Gopher Robot \nRun-TryBot: Cherry Mui ","shortMessageHtmlLink":"runtime: x_cgo_getstackbound: initialize pthread attr"}},{"before":"13e3068b9c0f8640207b1497d15b730b8e31bb51","after":"2fe2e4d593aaa01ca00ad861808846a2b3328b05","ref":"refs/heads/master","pushedAt":"2024-05-23T23:17:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/types, types2: document why Unalias is not needed in some places\n\nDocumentation change only.\n\nFor #67547.\n\nChange-Id: I0da480299c33239bcd1e059f8b9c6d48d8f26609\nReviewed-on: https://go-review.googlesource.com/c/go/+/587820\nTryBot-Bypass: Robert Griesemer \nReviewed-by: Robert Griesemer \nReviewed-by: Robert Findley \nAuto-Submit: Robert Griesemer ","shortMessageHtmlLink":"go/types, types2: document why Unalias is not needed in some places"}},{"before":"acc93dac8360640f860cf25985aebe7039bc71a5","after":"13e3068b9c0f8640207b1497d15b730b8e31bb51","ref":"refs/heads/master","pushedAt":"2024-05-23T21:17:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/types, types2: add missing Unalias call to type string functionality\n\nFor #67547.\n\nChange-Id: I999cd31f9a01f91e7984b4e7012c81e8bd9c6b06\nReviewed-on: https://go-review.googlesource.com/c/go/+/587940\nReviewed-by: Robert Griesemer \nAuto-Submit: Robert Griesemer \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/types, types2: add missing Unalias call to type string functionality"}},{"before":"019353d5323fcbffde939f4e85a68bd0093c6e14","after":"acc93dac8360640f860cf25985aebe7039bc71a5","ref":"refs/heads/master","pushedAt":"2024-05-23T20:49:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"doc/next: populate TODOs found with relnote todo\n\nThis is the first round of TODOs created based on relnote todo output.\nThere are many entries that need to be documented, expanded, reworded,\nand this change makes progress on setting that up.\n\nFor this cycle, relnote todo implemented a simple heuristic of finding\nCLs that mention accepted proposals (see issue 62376, or comment\nhttps://go.dev/issue/62376#issuecomment-2101086794 specifically).\nThe \"Items that don't need to be mentioned in Go 1.23 release notes but\nare picked up by relnote todo.\" section in todo.md contains an attempt\nat reviewing that list. The large number of items needed to be reviewed\nmade it impractical to spend much time on any individual one.\n\nFor #65614.\n\nChange-Id: Id9d5f1795575a46df2ec4ed0088de07ee6075a90\nReviewed-on: https://go-review.googlesource.com/c/go/+/588015\nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Carlos Amedee ","shortMessageHtmlLink":"doc/next: populate TODOs found with relnote todo"}},{"before":"128a99decdfd697f6426e3ee651e852081dd7ac5","after":"019353d5323fcbffde939f4e85a68bd0093c6e14","ref":"refs/heads/master","pushedAt":"2024-05-23T18:51:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"test/codegen: add Mul test for riscv64\n\nChange-Id: I51e9832317e5dee1e3fe0772e7592b3dae95a625\nReviewed-on: https://go-review.googlesource.com/c/go/+/586797\nReviewed-by: Keith Randall \nReviewed-by: Keith Randall \nAuto-Submit: Keith Randall \nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"test/codegen: add Mul test for riscv64"}},{"before":"bf91eb3a8bb057a620f3823e4d6b74a529c0a44d","after":"128a99decdfd697f6426e3ee651e852081dd7ac5","ref":"refs/heads/master","pushedAt":"2024-05-23T18:50:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link/internal/loong64: correct the musl dynamic linker path\n\nMusl libc already supports loongarch64, the dynamic linker path is the\nsame as other architectures: /lib/ld-musl-$ARCH.so.1\n\nRef: https://git.musl-libc.org/cgit/musl/tree/INSTALL#n141\n\nChange-Id: Ie31d4254f6e14a5d634b2a7b5fa4c6270e2c0dc7\nReviewed-on: https://go-review.googlesource.com/c/go/+/569475\nReviewed-by: Cherry Mui \nAuto-Submit: Cherry Mui \nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: abner chenc \nReviewed-by: sophie zhao \nReviewed-by: Qiqi Huang ","shortMessageHtmlLink":"cmd/link/internal/loong64: correct the musl dynamic linker path"}},{"before":"c34c124f4007e79978674ba519b9421665060186","after":"bf91eb3a8bb057a620f3823e4d6b74a529c0a44d","ref":"refs/heads/master","pushedAt":"2024-05-23T18:42:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"std: fix calls to Printf(s) with non-constant s\n\nIn all cases the intent was not to interpret s as a format string.\nIn one case (go/types), this was a latent bug in production.\n(These were uncovered by a new check in vet's printf analyzer.)\n\nUpdates #60529\n\nChange-Id: I3e17af7e589be9aec1580783a1b1011c52ec494b\nReviewed-on: https://go-review.googlesource.com/c/go/+/587855\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Russ Cox ","shortMessageHtmlLink":"std: fix calls to Printf(s) with non-constant s"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEU3FEQgA","startCursor":null,"endCursor":null}},"title":"Activity · golang/go"}