-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for fallbacks with context #128
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Gojek Team!
The fallback function provided by heimdall's Hystrix Client doesn't support
context.Context
.While going through afex/hystrix-go, I found that it does support a fallback function with context:
Link: https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L13
This can be used alongwith
DoC()
instead ofDo()
Link: https://github.com/afex/hystrix-go/blob/master/hystrix/hystrix.go#L217
This is however a breaking change.
Let me know if there's other way.
Thanks!
The text was updated successfully, but these errors were encountered: