database/gdb: fix confusing error message in Insert/Update operations when table not exist or the table contains no fields #3553
Conversation
database/gdb/gdb_core_structure.go
Outdated
| if toLowerTableName == table { | ||
| return nil, gerror.Newf("The table %s may not exist, or the field is 0", table) | ||
| } | ||
| return nil, gerror.Newf("The table %s may not exist, or the field is 0, you can try %s", table, toLowerTableName) |
There was a problem hiding this comment.
- 不用增加表名称的大小写判断逻辑，这里直接报错即可：
`The table "%s" may not exist, or the table contains no fields` - 下面的
415行可以增加完全过滤后的报错。 - 缺少单测。
gqcn
changed the title
gqcn
changed the title
database/gdb/gdb_core_structure.go
Outdated
| @@ -406,6 +409,9 @@ func (c *Core) mappingAndFilterData(ctx context.Context, schema, table string, d | |||
| delete(data, dataKey) | |||
| } | |||
| } | |||
| if len(data) == 0 { | |||
| return nil, gerror.Newf(`The insert/update fields are filtered and have a quantity of 0`) | |||
There was a problem hiding this comment.
看起来这里要把data keys作为数组[]string拿出来放到错误提示中：
gerror.Newf(`input data keys "%v" match no fields in table "%s"`, dataKeys, table)There was a problem hiding this comment.
看起来这里要把
data keys作为数组[]string拿出来放到错误提示中：gerror.Newf(`input data keys "%v" match no fields in table "%s"`, dataKeys, table)
不需要吧，要是太长了，影响阅读体验，或者可以把keys放到最后面
There was a problem hiding this comment.
看起来这里要把
data keys作为数组[]string拿出来放到错误提示中：gerror.Newf(`input data keys "%v" match no fields in table "%s"`, dataKeys, table)不需要吧，要是太长了，影响阅读体验，或者可以把keys放到最后面
那么就简化一下gerror.Newf(`input data match no fields in table "%s"`, table)
There was a problem hiding this comment.
看起来这里要把
data keys作为数组[]string拿出来放到错误提示中：gerror.Newf(`input data keys "%v" match no fields in table "%s"`, dataKeys, table)不需要吧，要是太长了，影响阅读体验，或者可以把keys放到最后面
那么就简化一下
gerror.Newf(`input data match no fields in table "%s"`, table)
ok，我没有给table加引号，因为到这里的时候table已经有引号了貌似，在使用"%s" 格式的输出会变成“”table“”
database/gdb/gdb_core_structure.go
Outdated
| @@ -406,6 +409,9 @@ func (c *Core) mappingAndFilterData(ctx context.Context, schema, table string, d | |||
| delete(data, dataKey) | |||
| } | |||
| } | |||
| if len(data) == 0 { | |||
| return nil, gerror.Newf(`The insert/update fields are filtered and have a quantity of 0`) | |||
There was a problem hiding this comment.
看起来这里要把
data keys作为数组[]string拿出来放到错误提示中：gerror.Newf(`input data keys "%v" match no fields in table "%s"`, dataKeys, table)不需要吧，要是太长了，影响阅读体验，或者可以把keys放到最后面
那么就简化一下gerror.Newf(`input data match no fields in table "%s"`, table)
当 更新/插入操作时，表字段数量为0，直接返回error，不在后续操作，具体请看 #3554