Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial using wrong class: "Using a Viewport as a texture" --> "Using a SubViewport as a texture" #9312

Open
blenderer opened this issue May 2, 2024 · 1 comment · May be fixed by #9326
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:shaders

Comments

@blenderer
Copy link

Your Godot version: 4.2.2

Issue description: I am new to Godot so correct me if I'm just wrong. It appears you can no longer add a "Viewport" to a scene. Viewport is greyed out (Abstract now?) and other documentation references adding "Subviewports". Perhaps this tutorial should be modified to use "SubViewport"

I am willing to contribute, just want to know if this is correct.

URL to the documentation page (if already existing): https://github.com/godotengine/godot-docs/blob/master/tutorials/shaders/using_viewport_as_texture.rst

@blenderer blenderer changed the title Modify tutorial: "Using a Viewport as a texture" --> "Using a SubViewport as a texture" Tutorial using wrong class: "Using a Viewport as a texture" --> "Using a SubViewport as a texture" May 2, 2024
@clayjohn
Copy link
Member

clayjohn commented May 2, 2024

Yep, that's correct. In Godot 4 the Viewport was made abstract and now users access the SubViewport. A lot of our docs are still out of date. Admittedly, we often casually call the SubViewport "Viewport", but we shouldn't do that in the documentation

@skyace65 skyace65 added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:shaders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants