Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class ref: Translations hide up-to-date information #17

Open
mhilbrunner opened this issue Jul 19, 2021 · 4 comments
Open

Class ref: Translations hide up-to-date information #17

mhilbrunner opened this issue Jul 19, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@mhilbrunner
Copy link
Member

Somehow, the translation ends up shadowing the original data, even if no translations for that page exist.

Consider the class docs for InputEventKey on master for the german locale:
https://docs.godotengine.org/de/latest/classes/class_inputeventkey.html

Looks good, even if its completely untranslated and english. But actually, its out of date. The original english page contains things like keycode instead of scancode:
https://docs.godotengine.org/en/latest/classes/class_inputeventkey.html

@mhilbrunner mhilbrunner added the bug Something isn't working label Jul 19, 2021
@akien-mga
Copy link
Member

The translations track the stable branch, so that's 3.3.2 docs.

@mhilbrunner
Copy link
Member Author

That makes some sense. Still unfortunate if there are no translations available anyway and it just displays the original english version... of another version. So 2 issues, really:

  1. Translations should be per branch (up to RTD, I guess?)
  2. Translations shouldn't shadow the original if there are no translations available. (Not sure if/what we can do thats not on RTD)

@akien-mga
Copy link
Member

It's not showing docs of another version, the localized docs only track the stable branch, so both https://docs.godotengine.org/de/latest/ and https://docs.godotengine.org/de/stable/ are the same 3.3.x documentation. The latest branch shouldn't even exist for now but removing it would break links.

We can't easily have multiple branches on Weblate, nor really have resources to maintain multiple branches of such humongous translations, so for now we only track the stable branch.

Once 4.0 is closer to release, I plan to switch the latest branch here (and thus Weblate) to properly track the latest branch of godot-docs. And thus the stable branch will be frozen.

@mhilbrunner
Copy link
Member Author

Ah. Is there a way to disable localisation on non-stable branches? Or at least to display a warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants