Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithBaseField example to traits.rs (#715) #716

Merged
merged 1 commit into from
May 22, 2024

Conversation

lokimckay
Copy link
Contributor

Closes #715

@lokimckay
Copy link
Contributor Author

Feel free to reword anything - I am a rust beginner so I may not be using the correct terminology :)

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-716

godot-core/src/obj/traits.rs Outdated Show resolved Hide resolved
godot-core/src/obj/traits.rs Outdated Show resolved Hide resolved
@lokimckay lokimckay force-pushed the patch-1 branch 3 times, most recently from e3db34c to 6896f6b Compare May 20, 2024 00:53
@lokimckay
Copy link
Contributor Author

I'm not sure how to run the unit tests locally but I think they should pass now

@Bromeon
Copy link
Member

Bromeon commented May 20, 2024

I'm not sure how to run the unit tests locally

https://godot-rust.github.io/book/contribute/dev-tools.html 🙂

@lilizoey
Copy link
Member

the current itest errors are because of godotengine/godot#90716 fixing an inconsistency with type string hints and unrelated to this PR

@Bromeon
Copy link
Member

Bromeon commented May 21, 2024

@lokimckay Could you rebase this onto master (fixed CI) and reduce the commits to a single one?

@lokimckay
Copy link
Contributor Author

@lokimckay Could you rebase this onto master (fixed CI) and reduce the commits to a single one?

done :)

@Bromeon Bromeon added this pull request to the merge queue May 22, 2024
Merged via the queue into godot-rust:master with commit 688ac92 May 22, 2024
15 checks passed
@Bromeon
Copy link
Member

Bromeon commented May 22, 2024

Thank you, and congratz to your first contribution! 🙂

@Bromeon Bromeon added the documentation Improvements or additions to documentation label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is tricky to figure out how to properly use WithBaseField generically
5 participants