Clean up old code related to PluggableTask and Package material config/preferences

[chadlwilson]

Summary

At some point it appears the metadata mechanism for plugins were changed within GoCD and the way metadata for plugins is registered with, understood by the server and agent was changed.

However there is deprecated code still lingering around, and it appears some clean-up code by done.

PluggableTaskConfig

gocd/plugin-infra/plugin-metadata-store/src/main/java/com/thoughtworks/go/plugin/access/pluggabletask/PluggableTaskConfigStore.java

Lines 24 to 25 in 4d89274

	@Deprecated
	public class PluggableTaskConfigStore extends PluginPreferenceStore<TaskPreference> {

gocd/plugin-infra/go-plugin-access/src/main/java/com/thoughtworks/go/plugin/access/pluggabletask/PluggableTaskPreferenceLoader.java

Lines 24 to 26 in 0f58107

	@Deprecated
	@Component
	public class PluggableTaskPreferenceLoader implements PluginChangeListener {

Possibly replaced by

gocd/plugin-infra/plugin-metadata-store/src/main/java/com/thoughtworks/go/plugin/access/pluggabletask/PluggableTaskMetadataStore.java

Line 21 in 0f58107

public class PluggableTaskMetadataStore extends MetadataStore<PluggableTaskPluginInfo> {

Package material config

gocd/plugin-infra/go-plugin-access/src/main/java/com/thoughtworks/go/plugin/access/packagematerial/PackageMaterialMetadataLoader.java

Lines 30 to 32 in 0f58107

	@Deprecated
	@Component
	public class PackageMaterialMetadataLoader implements PluginChangeListener {

Possibly replaced by

gocd/plugin-infra/go-plugin-access/src/main/java/com/thoughtworks/go/plugin/access/packagematerial/NewPackageMaterialMetadataLoader.java

Lines 24 to 25 in 0f58107

	@Component
	public class NewPackageMaterialMetadataLoader extends MetadataLoader<PackageMaterialPluginInfo> {

Expected Results

Remove the unnecessary logic and/or remove the deprecations if there is no viable path towards removal.

Additional detail

Generally these things were deprecated with 19b3e9c and #3600

Old plugin API versions

It's also worth noting that for most plugin-api types there is old code for old plugin versions still lying around that has never been removed - it seems the deprecations here did often not lead to removals. It may be that this is unrelated to the way plugin info/metadata is managed. All have been documented here since at least 21.2.0. Probably need to do a review of which plugins might break.

Plugins with more than one version:

• notification v1, v2, v3, v4
• elastic agent v4, v5
• config repo v1, v2, v3
• analytics v1, v2

[chadlwilson]

Hello @ketan - I know this is a very long time ago (2017!), however if you have any recollections here about the intended direction for these deprecations/removals that'd be useful to know. (e.g were they already replaced by some other mechanisms awaiting migration of plugins/API removals, or were the deprecations intended to indicate "we need to do more work here"?

[ketan]

I looked at this. I don't particularly recall what we decided in terms of removal of the code (and the impact it may havve on breaking plugins). Your call on how you want to remove the code.