Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articles with bad dates generates error in stdout #49

Open
jvegaseg opened this issue Mar 9, 2024 · 1 comment
Open

Articles with bad dates generates error in stdout #49

jvegaseg opened this issue Mar 9, 2024 · 1 comment

Comments

@jvegaseg
Copy link

jvegaseg commented Mar 9, 2024

It is very annoying.

Affected line is in function getParsedDate:

fmt.Printf("Failed to parse date \"%s\"\n", dateStr)

Could it be avoided?

Regards

@fmartingr
Copy link
Member

Hey #48 removed this log line, but right now it is the only way we know of time parsing failures easily in the logs. I've requested to add it back, but it seems that some of you think it should be gone.

I'm all in for it to be gone if we refactor the getParsedDate function to return an error when it fails to parse the datetime, ignoring it in the consumer if it's not needed. That's the way it should be done.

cc: @vlanse @rmarku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants