Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the final URL as the page URL #36

Merged
merged 1 commit into from
May 18, 2024
Merged

Use the final URL as the page URL #36

merged 1 commit into from
May 18, 2024

Conversation

przemekd
Copy link
Contributor

@przemekd przemekd commented Aug 17, 2023 •
edited

Fixes #35

fmartingr
fmartingr approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and the quick resolution. Small change but high impact :)

Thanks for the contribution!

I'm going to request @RadhiFadlillah review as well, since he's the one doing the maintenance of this project.

@fmartingr fmartingr merged commit ec24db0 into go-shiori:master May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmartingr fmartingr fmartingr approved these changes

@RadhiFadlillah RadhiFadlillah Awaiting requested review from RadhiFadlillah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirection breaks fixRelativeURIs
2 participants
@przemekd @fmartingr