grpc stream use async socket send, but seem use them same buffer, the newer msg seems overwrite the underlying buffer

[dashessmith]

[dashessmith]

this bytes.buffer seems not thread safe

[DingYuan0118]

Encounter the same problem. Use grpc server seems to avoid this

[DingYuan0118]

Seems all buf in channel use the same pointer which point to the underlying []byte since buf.Reset() does not change buf's address buf.Bytes() always return the same pointer.

use copy() to make a new []byte and then put it into channel can solve this.

func TestBuffer(t *testing.T) {
	wg := sync.WaitGroup{}
	defer wg.Wait()

	var ch = make(chan []byte, 128)
	wg.Add(1)
	go func() {
		defer wg.Done()

		buf := bytes.Buffer{}

		defer close(ch)

		for i := 1; i < 10; i++ {
			buf.Write([]byte(fmt.Sprintf("%v", i)))
			bs := buf.Bytes()
			buf.Reset()
			b := make([]byte, len(bs))
			copy(b, bs)
			ch <- b
		}

	}()

	wg.Add(1)

	go func() {
		defer wg.Done()
		for x := range ch {
			fmt.Printf("i:=%v\n", string(x))
		}
	}()
}


i:=1
i:=2
i:=3
i:=4
i:=5
i:=6
i:=7
i:=8
i:=9

[DingYuan0118]

Change like this seems to make it work normal.