Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Events support #588

Open
jdblack opened this issue Mar 23, 2021 · 4 comments
Open

[FR] Events support #588

jdblack opened this issue Mar 23, 2021 · 4 comments

Comments

@jdblack
Copy link

jdblack commented Mar 23, 2021

Is your feature request related to a problem? Please describe.
We have a moderately large graphite stack (2.1 mil metrics/sec) that we are currently serving with graphite-web because of it's event support.

Is event support on the roadmap? Is database support the main blocking issue?

@deniszh
Copy link
Member

deniszh commented Mar 23, 2021

Hi @jdblack ,

As far as I know events never was in the scope of this project.
But what stopping you from switching rendering to carbonapi while keeping events on old setup? If it will not serve rendering it can be significantly reduced.

@Civil
Copy link
Member

Civil commented Mar 23, 2021

Basically @deniszh is right.

Actual database support is not a big deal, as we have aliasByPostgres in there will be also way to do alias by redis in near future.

It's something that is nice to have eventually, but it would require some effort to understand how it's implemented in graphite-web and to make it compatible. Plus I've never seen anyone who had a use case for them. It's always harder to implement something that you don't know how to use :)

But I'm willing to accept a PR that would implement graphite-compatible event function.

At this moment maybe it would be better to proxy this function with graphiteWeb function (it's possible to configure it to be a transparent proxy, however since I've implemented it I haven't heard a lot of feedback about it, so either it works perfectly or no one uses it enough to file bugs)

@Felixoid
Copy link
Collaborator

My five cents: we use grafana annotations in the company

@deniszh
Copy link
Member

deniszh commented Mar 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants