-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grc: fix showing docs from wrong block and add doc tab to qt #7271
base: main
Are you sure you want to change the base?
Conversation
@ZakyHermawan does the bug exist in the Qt version, and if so is there an equivalent fix? |
6ef17e1
to
c26bd67
Compare
Would you remove the documentation for the max block and submit that as a separate PR? We can work on the wording a little there. I'll get the code part of this in for this release. |
This PR causes a failure when opening disable blocks. Let's hold off until the next release. A lot of blocks don't have any documentation in this field anyway and rely on the wiki ... something we need to think about. |
@willcode would you please give an example on how to reproduce the bug ? I can open properties of disabled max block Btw I make mistake where i didn't set the textedit for documentation to readonly (i have fixed this on my latest commit) |
The QT Sink block is the one that didn't work in my test, when disabled. It evenutally caused a crash. If you can't replicate it, I'll look through the rather messy stack trace it caused before crashing. |
…d documentation tab in qt gui of grc Signed-off-by: ZakyHermawan <[email protected]>
I'm able to reproduce with a disabled qt sink block. Here's the trace:
|
Actually, the error appears with GRC Gtk too! But it doesn't crash the application |
Description
Related Issue
Fixes #7265
Which blocks/areas does this affect?
Max block
Testing Done
max block now have correct documentation
docs for another blocks still working properly, here's few examples
Checklist