Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 1.12-1.13 spot permaloaders don't work with optimizedTileEntities = true #57

Open
Earthcomputer opened this issue Oct 25, 2018 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Earthcomputer
Copy link
Collaborator

These permaloaders haven't been released or fully researched yet.

@Earthcomputer Earthcomputer added the bug Something isn't working label Oct 25, 2018
@Earthcomputer Earthcomputer self-assigned this Oct 25, 2018
@susanshopper
Copy link

What permaloader type are you talking about? Is it the beacon permaloader which uses sticky pistons with slime blocks that push and pull stained glass to cause beacon updates?

@Earthcomputer
Copy link
Collaborator Author

Back in 2018, when we in the monkeys discord were first looking into the potential for ender chests to load chunks, we called them "spot permaloaders". I'm not sure what the common name for them is these days, probably just "ender chest loaders".

@susanshopper
Copy link

Somewhere in the code, when optimizedTileEntities=true, it disables the code that makes ender chests load chunks. May you please take a look at TileEntityEnderChest.java.patch(the carpet patch) and minecraft/net/minecraft/tileentity/TileEntityEnderChest.java(Vanilla code)?

@Earthcomputer
Copy link
Collaborator Author

I know. However I am not the maintainer of this repository anymore.

@susanshopper
Copy link

susanshopper commented Aug 20, 2020

A potential fix: With this fix, if optimizedTileEntities is True, the ender chest’s chunk loading mechanic only deactivates in a player loaded area or the spawn chunks. It can also keep ender chest reloaders from activating inadvertently from the player leaving at the right time if the reload mechanic reactivation is delayed at that time. The fix can be a carpet rule so ender chest reloaders can be deactivated by setting it to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants