Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short hand syntax should support FIFO queues #25

Open
2 of 4 tasks
gmetzker opened this issue Jan 29, 2017 · 5 comments
Open
2 of 4 tasks

Short hand syntax should support FIFO queues #25

gmetzker opened this issue Jan 29, 2017 · 5 comments

Comments

@gmetzker
Copy link
Owner

gmetzker commented Jan 29, 2017

SQS recently added support for 'fifo' queues.
If Cloudformation supports this perhaps the plugin can support it to. Use a regex match .fifo$ to see if the queue name ends with .fifo.

If the queue name ends with .fifo then create a fifo queue by:

  • Set attribute: FifoQueue: true ?
  • Consider setting ContentBasedDeduplication: true or what ever the default queue attributes on when you create a fifo queue on the AWS web ui console.
  • Determine the default fifo queue attributes

  • Determine if Cloudformation supports this what what the syntax looks like

  • During compilation time determine if the queue name matches the fifo format

  • Create the queue with the default fifo attributes if it should be a fifo queue.

Potential syntax

  # 'functions' in serverless.yml

functions:
  createUser: # Function name
    handler: handler.createUser # Reference to function 'createUser' in code

    deadLetter:
      sqs:  createUser-dl-queue.fifo
@gmetzker gmetzker added this to the v1.2 milestone Jan 29, 2017
@gmetzker
Copy link
Owner Author

FIFO queues are not support by Cloudformation at this time. Once this is added to CF we can fix this.

@gmetzker gmetzker removed this from the v1.2 milestone Jan 31, 2017
@kitsunde
Copy link

It is now: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-sqs-queues.html

@jayasai470
Copy link

@gmetzker any work going into this plugin for support of fifo queues ?

@jantpedraza
Copy link

Hi! Same here, I would really like to use this plugin using FIFO queues. Any plan to update it?

@timothy-mugayi
Copy link

There's a real need to support FIFO for DLQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants