-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion #75
Comments
|
Idomo
added a commit
to Idomo/BetterSegmentedControl
that referenced
this issue
Oct 1, 2018
Set `layer.masksToBounds` to true only if `indicatorViewInset` isn't negative to achieve the effect I mentioned in gmarm#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @gmarm,
First thing, thanks for building this library, it's great and exactly what I was needed!
I'd like to suggest few things to change, to make the library even better:
Make settings
options
more easier to understandIn the beginning I thought there is no way to change it, but now I find out that I can change it via
options
property, it's not the most understandable way and I couldn't find any examples in theREADME.md
or in the Example project, I think you should do something about it.Remove
layer.masksToBounds = true
from line 310 whenindicatorViewInset
is negativeWhen the
indicatorViewInset
is negative you should get nice effect like this:But instead of that the
indicatorViewBackground
is cutting of when it's passing theBetterSegmentedControl
parent view because of this line.I don't see any problem after comment it out so it's just unnecessary.
I'v created pull request for this: #87
Thanks,
Ido.
The text was updated successfully, but these errors were encountered: