-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable @typescript-eslint/no-floating-promises
#29
Labels
enhancement
New feature or request
Comments
This can be enabled if you create a N.B. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Needed to make sure the promises are awaited/returned. Currently if you aren't careful enough, often you'll miss that a particular function is async and it should've been awaited. For example - router.replace here - https://github.com/globalbrain/sefirot/pull/406/files#diff-06e685d5200cf3dbea4fd7986f71b9bab23e0c6b85d19e69fefb1ac45be0d041
This rule requires type-information. I'm not sure how tricky that would be for us 👀
PS: Also enable - https://typescript-eslint.io/rules/require-await/
The text was updated successfully, but these errors were encountered: