React Hooks version of react-collapsible

[glennflanagan]

@iMoses has created a really nice-looking Gist of the way React Collapsible could move forward using React Hooks (#228)

If we can we would want this to be backwards compatible - or at least still offer a version of React Collapsible that doesn't require React Hooks.

This discussion is open to all who would like to offer advice/requirements and/or like to help out move this forward.

[gioragutt]

Basically if I understand correctly the book contains all the logic contained by Collapsible. The refactor could be that Collapsible would use the hook under-the-hood, and so you'll have both the Hook and the Component versions.

[iMoses]

I think it shouldn't be a problem to create the exact same interface and output using a hook under the hood, question is if we want to create an exact replica which is 100% backward compatible, maybe polish the interface a little or potentially do/offer both.

I'll work on a compatible component and will provide an example soon...

[karltaylor]

Hey @iMoses might be a big ask but is there anyway we can build it in typescript?

[karltaylor]

Also I think I tried to add this to a previous v3 to change the way some of the class logic worked:

#87

[iMoses]

I don't mind adding TS, but if that's the case I'll probably upgrade all the infrastructure.

Regarding #87 - as I previously said I think that v3 should export 3 entities. The hook, a 100% backwards compatible component utilizing the hook, and a new version of the component which introduces a cleaner interface which will not be compatible (although migrating would be easy)

and I think that regarding the entry points it should be that react-collapsible would provide the new version while react-collapsible/legacy (or something of the sort) would provide the compatible version so that the migration between v2 and v3 could simply be search & replacing the import if they don't wish to change anything right away.

WDYT?

I'll come back with a code example once I have the time :)

[karltaylor]

I'm not sure it needs to be backwards compatible, we can simply release a new major version 3.0.0, I think doing a /legacy thing might get a little convoluted for the contributors and for community using it, don't you think?

[iMoses]

@karltaylor sorry, I missed the last message
I tend to agree with you, I think a "legacy" version can be "exampled" as part of the documentation, outside of the package.

@glennflanagan note that a typescript version of the code is sitting idle for a couple of months now :)
I'm still in favor of publishing it and am willing to put in the time
I only require your consent and review

https://github.com/iMoses/react-collapsible/blob/imoses/v3-rc/src/useCollapsible.ts