-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposals (Political/Workflow) #570
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current index.php does several things as the common entry point to the application:
The result is that neither index.php nor application/bootstrap.php can bootstrap the application on their own, and it is impossible to include the Kohana environment in any non-Minion CLI tool (PHPUnit, Behat, Doctrine, etc) without duplicating the index.php definitions.
Though less significant, this also makes it more tricky than necessary to move the index.php down to an explicit web document root for security - all the path definitions in index.php have to be updated and you also cannot use the stock unittest bootstrap which forces a standard (index.php at root) layout.
I propose that for 3.4 we tidy up this structure so that:
This would make the structure neater with more clearly defined responsibilities, and make it much simpler to use the Kohana environment in other contexts. It would also mean that if moving the index.php within an otherwise standard Kohana folder structure the only required change would be to update the
require 'application/bootstrap.php'
that would now be the first line in index.php.http://dev.kohanaframework.org/issues/4777
The text was updated successfully, but these errors were encountered: