-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Compiler never empties the stale tracker #3141
Comments
Here's an example patch of what I'm suggesting: I might be missing something though as the comment here specifically mentions clearing the caches for LSP
|
Ah! I'm not very fresh on this code so I'm not sure what the consequences are here. What is it that happens due to forgetting to reset this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The project compiler empties the stale tracker immediately when compiling
gleam/compiler-core/src/build/project_compiler.rs
Line 154 in 2c59b9c
However, when calling package_compiler.rs's compile() via the LSP, we don't empty the stale_tracker because we sidestep the
ProjectCompiler
by compiling using theLspProjectCompiler
, which does not clear the stale tracker.I think the line that we should empty the stale tracker would be right above here
gleam/compiler-core/src/language_server/compiler.rs
Line 102 in 2c59b9c
The text was updated successfully, but these errors were encountered: