-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fails with multiple mining clients (at least for nheqminer) #6
Comments
Looking closer at the code, it seems all this proxy does is relaying all messages back and forth between the pool and miners, and altering the What's needed is a proper proxy that acts as a single miner to the pool, subscribing itself to the pool and dealing with the A state machine is needed to implement the above. It's not a simple hack. You made a good start though. |
It doesn't seem to work with multiple miners on different machines. I tried the nheqminer with CPU mining and the flypool pool.
In a normal miner->pool communication, the
id
field in the packets is incremented with every exchange of packets (excluding pool broadcasts). Your code alters theid
field to be equal to the miner'sid
, essentially keeping it fixed for each miner. You also pass the same job to all miners. There are a number of problems that are happening:id
is not equal to 1 (here theid
is equal to 5 because it was the 5th connecting client, which the proxy incremented to 5 and then keeps it at 5):launch proxy
,launch miner 1
,launch miner 2
then miner 2 fails and exits saying it's not authorized (looking at the messages, the pool responds with the same Extranonce1 and Extranonce2_size to the mining.subscribe request of miner 2 ...It seems that your proxy hasn't really been tested with multiple miners, or with different mining software (see my other raised issue about EWBF). It would be nice if you looked into it.
The text was updated successfully, but these errors were encountered: