-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MotionBlurPass doesn't work with three v0.131.1 or above #26
Comments
Hello! I don't maintain all of these examples to keep them up to date but I'm happy to take a PR for them if you have any fixes. I'm sure it could be fixed by removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for putting this repo together, really helpful to see some example code!
I ran into an issue with the
motionBlurPass
example that I think boils down to the these lines.threejs-sandbox/motionBlurPass/src/MotionBlurPass.js
Lines 164 to 166 in a8b6f66
Based on the comment, the call to
renderer.compile
is used to setcurrentRenderState
in the renderer because it's then subsequently used inrenderer.renderBufferDirect
. However this three PR (mrdoob/three.js#22220) now setscurrentRenderState = null
at the end of therenderer.compile
call.Totally understand that
renderer.renderBufferDirect
isn't supposed to be part of the public API so a quick solution might not be feasible, but wondering if you (or people stumbling into this issue) have any thoughts.The ultimate error I'm seeing is
Cannot read properties of null (reading 'state')
fromsetProgram
inside WebGLRenderer on this line:The text was updated successfully, but these errors were encountered: