Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Gitify menu bar (Mac) tray it has some indication that you "approved", "requested changes", or "commented" on the PR #682

Closed
bhingston-va opened this issue Nov 16, 2023 · 0 comments · Fixed by #1078
Assignees
Labels
enhancement New feature or enhancement to existing functionality help-wanted Extra attention is needed

Comments

@bhingston-va
Copy link

📝 Provide a description of the new feature

Where

In the notifications tray from Gitify menu bar icon. For each tray item it would be nice to have some indication if I approved, requested changes, or just commented on it.

Problem space

I often will approve a PR and a conversation will continue between other people (this can be very noisy). Some pull requests I want to engage and others I want to unsubscribe. However, for the life of me, I cannot recall or identify pull requests by the title and cannot remember if I reviewed it or not.

When I click on a tray item it removes it out of the tray (as expected) but then it is gone and I can't click unsubscribe through Gitify's tray item (I suppose I could through GitHubs notifications but I like Gitify).

A suggested solution might be

Have an icon/badge for the tray item that indicates if I approved it already. Then I can choose to open or unsubscribe.

The "request-changes" comes up less frequently but is an interesting use case as it would help me prioritize which ones to review since if I'm blocking a pull request I would likely want to review those changes faster to unblock the person. Not really an issue as the person could dismiss my review.

➕ Additional Information

No response

@setchy setchy added the help-wanted Extra attention is needed label Feb 16, 2024
@setchy setchy added enhancement New feature or enhancement to existing functionality and removed feature-request labels Feb 29, 2024
@setchy setchy self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality help-wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants