Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to use Gitify Notification type #828

Open
setchy opened this issue Feb 27, 2024 · 0 comments · May be fixed by #1033
Open

refactor to use Gitify Notification type #828

setchy opened this issue Feb 27, 2024 · 0 comments · May be fixed by #1033
Assignees
Labels
refactor Refactoring of existing feature

Comments

@setchy
Copy link
Member

setchy commented Feb 27, 2024

📝 Provide a description of the new feature

Currently, a lot of the logic uses the raw GitHub response types (REST and GraphQL).

I'd like to propose we refactor to use a Gitify specific Notification type (eg: GitifyNotification) that contains only the fields required for the experience (eg: title, color, icon, type, state, timestamp, url), and avoid passing around/using the raw response types.

➕ Additional Information

No response

@setchy setchy added the refactor Refactoring of existing feature label Feb 27, 2024
@setchy setchy self-assigned this Apr 8, 2024
@setchy setchy linked a pull request Apr 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant