Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where can I find some documentation about URL parameter? #18

Open
aborruso opened this issue Jun 1, 2021 · 9 comments
Open

Where can I find some documentation about URL parameter? #18

aborruso opened this issue Jun 1, 2021 · 9 comments

Comments

@aborruso
Copy link

aborruso commented Jun 1, 2021

Hi,
when I apply a filter I see something like:

?filename=dati%2Fsomministrazioni-vaccini-latest.csv
&filters=fornitore%3DJanssen
&sha=9e6a9f4a150e6b96ef52827e0e2692274d68701e
&sort=data_somministrazione%2Cdesc
&stickyColumnName=data_somministrazione

For some I can deduce the meaning. Is there a page with documentation?
What's a stickyColumnName, what is it for?
What's the date format I must use for date fields? etc.

Thank you

@RandomFractals
Copy link

I second that request. Your flat data viewer has some nifty params to pull data from commits, etc. Would be good if they were documented in this repo for us to explore data files with different url params to create and share custom data URL views.

Thanks!

@Wattenberger
Copy link
Contributor

The url params mirror the current state of the table, for example the "stickyColumnName" represents the leftmost-column, which sticks when you scroll right. For creating and sharing URLs, you should be able to just filter and sort as you please, then share the current url - way easier than URL hacking.

I'd love to hear about any use cases where that's not an option, though!

@RandomFractals
Copy link

yeah, but I think you can create a simple md table in docs to document those parts.

@aborruso
Copy link
Author

aborruso commented Jun 2, 2021

I'd love to hear about any use cases where that's not an option, though!

A simple one: use fully the filters.

An example. Here I would like to filter date from 2021-03-21 to 2021-04-05. Using only the GUI I'm not able to do it. But using and understanding URL parameters, having a URL parameters README I could build a right URL, the URL I need, using unixtimestamp &filters=<myfield>=<start>,<stop>.

The same using filter on codice_regione_ISTAT. I'm not able via GUI to filter only the 19 region. Once again having a documentation I could write &filters=codice_regione_ISTAT=19,19.

image

Thank you

@RandomFractals
Copy link

RandomFractals commented Jun 2, 2021

@aborruso that's a perfect example. I was also looking for something like that param line example you provided but in md table that describes each param function and uses similar syntax for examples in description column.

does not have to be fancy

Parameter Name Parameter Values Description
filters <field1>=<start><stop>,<field2=...> Filter to apply to the flat data view

where:

<start> - start value ...
<end> - end value ...
...

@aborruso
Copy link
Author

aborruso commented Jun 2, 2021

Yes @RandomFractals . I think it would be very useful to add the value type: in example for field mapped as date it's necessary to use Unix timestamp, etc.

@RandomFractals
Copy link

right, so, I think supported data types and filter data formats should be listed too. good point!

@Wattenberger
Copy link
Contributor

Since this isn't supported functionality, it's important to be careful how we document "url-hacking". However, I can see that documentation being useful, if either of you wants to take a stab at it.

The relevant code lives in these two places:

https://github.com/githubocto/flat-viewer/blob/main/src/components/repo-detail.tsx#L39-L40
https://github.com/githubocto/flat-viewer/blob/main/src/components/json-detail-container.tsx#L24-L30

@RandomFractals
Copy link

RandomFractals commented Jun 2, 2021

I'll let @aborruso take a stab at it since he initiated this convo. Good to know where to look tho. Thanks for those code links.

btw, I was going over your open requests. Added this bit for folks looking for charts for now: #17 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants