New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Line Height #169

Open

7flash opened this issue Dec 2, 2023 · 0 comments

7flash commented Dec 2, 2023

In my app I have to specify manually default line height

https://github.com/excalidraw/excalidraw/blob/42d8c5a0401c47e8f88680db189205085df4cdb2/src/element/textElement.ts#L968

Please advice which values to choose for Monaspace Radon, Krypton, and Argon

7flash mentioned this issue

Feat: Add additional fonts support excalidraw/excalidraw#7375

Open

ottta added a commit to ottta/monaspace that referenced this issue


Resolve githubnext#21 githubnext#37 githubnext#169

d68bcf3

- githubnext#21 githubnext#37 "Hanging Font": Miss configure `typo` and `hhea` value. Adjust this value will "centering" glyphs across the vertical bounding box.

- githubnext#169  Probably same as above, tweaking `typo` and `hhea` does resolve the `line-height` or `leading` default to `1.2` or `120%` from the upm value.

UPM = 2000
(typo/hhea)Ascenders = 1930
(typo/hhea)Descenders = -470
(typo/hhea)LineGap = 0

Total:
ascender + abs(descenders) + linegap = 2400

Note that "Gcommaaccent" may be truncated in environments that have `overflow: hidden`

Please see these documentation:
- https://googlefonts.github.io/gf-guide/metrics.html#6-winascent-and-windescent-values-must-be-the-same-as-the-familys-tallestdeepest-ymin-and-ymax-bounding-box-values
- https://googlefonts.github.io/gf-guide/metrics.html#11-the-sum-of-the-fonts-vertical-metric-values-absolute-should-be-20-30-greater-than-the-fonts-upm

ottta mentioned this issue

Resolve several major issues: Vertical Metrics, Monospace Recognition #227

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment