Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nop on PRs doesn't work for environments #551

Open
linus345 opened this issue Nov 8, 2023 · 0 comments
Open

Nop on PRs doesn't work for environments #551

linus345 opened this issue Nov 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@linus345
Copy link

linus345 commented Nov 8, 2023

Problem Description

safe-settings supports running in a nop mode which will report the changes that will happen in a PR comment. Recently Environments support was added in #544 but this does not seem to work with the nop mode. When we opened a PR adding an environment it went and applied those changes directly before the PR was merged to master.

What is actually happening

Opening a PR adding an environment to a repo will add it when running the nop mode in the PR checks and then not report any changes in the PR comment.

What is the expected behavior

Opening a PR adding an environment should report the changes being made in the PR comment and only apply the changes when the PR is merged to master.

Error output, if available

N/A

Context

Are you using the hosted instance of probot/settings or running your own?

Running our own.

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

2.1.0 (latest stable)

Version of GitHub Enterprise

N/A

@linus345 linus345 added the bug Something isn't working label Nov 8, 2023
stevoland added a commit to eeveebank/safe-settings-public that referenced this issue Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant