-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On pull request, check run Safe-setting validator
is created but never runs ("Not working on a PR, returning...")
#540
Comments
Hi, I am able to recreate this. Looking into why the there are no pull_requests. Safe-settings is making that assumption that it would be there but it appears for forks the field is not populated. This does not happen when working on a branching based PR workflow; only with forks. Checking to see if a different way of triggering a check_run would work. |
Hi, |
@decyjphr thanks for the investigation. I am still not sure whether this should be considered a Github bug (because the PR field isn't populated for fork-based PRs) or a limitation of safe-settings. I've also poked my Github Enterprise support ticket on this question. If changing the Github-side behavior is not possible, a thought on a mitigation: The sequence of events that I have observed is:
It seems safe-settings could remember the Is this direction something that could be considered? |
Problem Description
I am seeing a non-deterministic issue with pull requests to the admin repo (we are using the fork model, so the pull requests come from a fork of the repo). Sometimes, the head commit on these pull requests has a pending (yellow)
Safe-setting validator
check run created with a description ofQueued — Waiting to run this check...
, but nothing more happens. The check run never completes.What is actually happening
The check run stays yellow/pending and never completes
What is the expected behavior
The check run eventually completes.
Error output, if available
With debug logging enabled, I see that safe-settings reacts to
pull_requests.opened
and creates a check run and then reacts to acheck_run.created
event.However, the handling stops with error message
Not working on a PR, returning...
here.Looking at the Webhook Deliveries for my app, I indeed see that
check_suite.pull_requests
is empty (even though it was created by safe-settings. So it is not surprising that the check above is failing.At this point I am not sure if this is
check_suite.pull_requests
, or whetherContext
Are you using the hosted instance of probot/settings or running your own?
Our own.
If running your own instance, are you using it with github.com or GitHub Enterprise?
github.com
Version of probot/settings
2.0.25
Version of GitHub Enterprise
The text was updated successfully, but these errors were encountered: