Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron Schedule not recognizing changes to Pull Request settings #528

Open
omrirosner-clx opened this issue Sep 24, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@omrirosner-clx
Copy link

Problem Description

After disabling/enabling allow merge commits or allow rebase merging, the settings do not change automatically, even if there is a change compared to the actual configuration.
However, when changing another field, the change is recognized and the cron job also changes the Pull Request settings.

What is actually happening

Changes to Pull Request settings are not recognized as changes.

What is the expected behavior

When changing pull request changes, in the next cron schedule, the settings should be seen as changed.

Context

Are you using the hosted instance of probot/settings or running your own?

Running our own

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

2.0.23-rc.11

@omrirosner-clx omrirosner-clx added the bug Something isn't working label Sep 24, 2023
@jyoder-deloitte
Copy link

The following settings are all ignored unless something else changes:

allow_squash_merge
allow_merge_commit
allow_rebase_merge
delete_branch_on_merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants