Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: always exclude Issues that are "Closed as not planned" aka: state_reason: not_planned #1038

Open
vordimous opened this issue Jan 31, 2024 · 3 comments

Comments

@vordimous
Copy link

Describe the bug
Closing issues with reason:"not planned" shouldn't be included or should be under a different section.

@olleolleolle
Copy link
Collaborator

There is a Label-based setting --exclude-labels.

Its default is:

exclude-labels=duplicate,question,invalid,wontfix,weekly-digest,dependencies

Are you referring to a Label?

@vordimous
Copy link
Author

vordimous commented Jan 31, 2024

I mean, when I close issues as not planned:

image

There isn't a label assigned that I know of and the default exclusion rules seem to line up with the flavor text under the Close as un planned option. GitHub adds a reason: "not planned" attribute to the issue.

@olleolleolle
Copy link
Collaborator

This feature was added in May 2022, and can be read about in this release announcement https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

We have added a new state_reason attribute to our REST API, GraphQL API and webhooks. These are currently in preview and will be fully shipped in the upcoming week.

Some of the REST docs currently say: https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#get-an-issue

state_reason: string or null

The reason for the state change. Ignored unless state is changed.

Can be one of: completed, not_planned, reopened, null.

I think a sensible default would be "always exclude state_reason: "not_planned".

Let's mark this Issue a feature request.

@olleolleolle olleolleolle changed the title Issues that are closed with reason:"not planned" are inlcuded Feature Request: always exclude Issues that are "Closed as not planned" aka: state_reason: not_planned Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants