-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows access denied errors/gitbutler deleting files #3560
Comments
Thanks so much for reporting! I am also very sorry to see that files were deleted, and hope that these docs on data recovery with GitButler can help getting them back. But, having recently worked on the After all, when files are changed, it will recalculate a lot of things and read files in the process. This happens in parallel to the ongoing changes in the working tree, preventing the removal of files. In theory, filesystem events should be bundled into 100ms time-slices, but judging from the log this doesn't really happen here as these events are apparently more frequent than that. But even if it would work, then the changing operation could still not take longer than 100ms, or else the recalculation would already kick in. And even if this window would be larger than 100ms, there is always a chance that a change takes longer than that. The only way to truly prevent 'stepping onto ones feet' is to assure reads are never interleaved with writes, something that cannot currently be done but of course is possible. |
@Byron thanks for the link, fortunately I've not lost anything unrecoverable so far but I wasn't aware of that data recovery documentation which I'm sure will come in handy. I'm not a rust guy but I'm happy to test future fixes or help in anyway I can. Here's another person on discord with (possibly) the same issue causing problems with changes being locked: |
gitbutler 0.11.3 for windows very often has issues with locked files/access denied errors on my machine. Running windows 11.
When these errors pop up, it permanently deletes the file(s) that were erroring, resulting in a loss of data.
This might be a dupe of #3412, but I'm opening a new issue because I have no explorer windows, command prompts, or VS Code instances open, and file locksmith shows no handles/processes with locks on the files that show up in the error logs.
Is it possible gitbutler is locking/blocking it's own access to files somehow?
Here's an example:
deleting a branch after it's merged
In this example,
filesystem.py
was deleted and no longer exists on the disk.There might actually be two issues here. I think the
ERROR set_base_branch: crates\gitbutler-tauri\src\virtual_branches.rs:138: error=Error(failed to checkout tree
call is destructively removing changed files before erroring and not putting them back. But I'm also not sure where theAccess is denied
error is coming from in the first place.I've also experienced this same issue when unapplying branches, updating the workspace, and switching back to gitbutler (after checking out the main branch elsewhere)
The text was updated successfully, but these errors were encountered: