Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning link doesn't point to anything anymore #3938

Closed
TeaDrinkingProgrammer opened this issue Apr 28, 2024 · 1 comment · Fixed by #3945
Closed

Warning link doesn't point to anything anymore #3938

TeaDrinkingProgrammer opened this issue Apr 28, 2024 · 1 comment · Fixed by #3945

Comments

@TeaDrinkingProgrammer
Copy link

The following warning points to a nonexistent link:

[GIN-debug] [WARNING] You trusted all proxies, this is NOT safe. We recommend you to set a value.
Please check https://pkg.go.dev/github.com/gin-gonic/gin#readme-don-t-trust-all-proxies for details.

Environment

  • go version: 1.22.2
  • gin version (or commit ref): v1.9.1
  • operating system: Linux
@snowdusk
Copy link

Readme's git logs show that
'Don't trust all proxies' was added on commit 2d3d6d2 (2021/10/24)
and was removed on commit 82e1c53 (2023/01/02, messags is 'docs(readme): move more example to docs/doc.md')
So readme-don-t-trust-all-proxies is https://github.com/gin-gonic/gin/blob/master/docs/doc.md#dont-trust-all-proxies

@codespearhead codespearhead mentioned this issue May 2, 2024
Merged
appleboy pushed a commit that referenced this issue May 7, 2024
@codespearhead
docs(gin): update link to dont-trust-all-proxies section (#3938) (#3945)
f5f5da8 
Update link [1] to [2] after PR #3449 was merged.

[1] https://pkg.go.dev/github.com/gin-gonic/gin#readme-don-t-trust-all-proxies
[2] https://github.com/gin-gonic/gin/blob/master/docs/doc.md#dont-trust-all-proxies

Closes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(gin): update link to dont-trust-all-proxies section (#3938) codespearhead/gin
2 participants
@TeaDrinkingProgrammer @snowdusk