Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

Committer/maintainer status #97

Open
jayvdb opened this issue Aug 14, 2018 · 2 comments
Open

Committer/maintainer status #97

jayvdb opened this issue Aug 14, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@jayvdb
Copy link

jayvdb commented Aug 14, 2018

Tightly related to #36 , committer/maintainer should be separate from the percentage of contributions.

Older developers on large established codebases often will fall short of any contribution threshold, as they spend more time doing code reviews and merging. In a repo which uses fast-forward merges, their effort will be hidden from typical analysis.

c.f. all-contributors/all-contributors#81

@lourot
Copy link
Member

lourot commented Aug 14, 2018

Makes sense, thanks @jayvdb!

For reference our related chats that contain useful details:

@lourot lourot added the enhancement New feature or request label Aug 14, 2018
@jayvdb
Copy link
Author

jayvdb commented Aug 20, 2018

The easiest way to determine write permission is via GitHub commit metadata , and to reduce work required it would be 'good enough' to only inspect committee for the pull requests the user created , as that data is already fetched.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants