Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Each interest activity creates a new assest profile #3381

Open
lildude opened this issue May 5, 2024 · 2 comments
Open

[BUG] Each interest activity creates a new assest profile #3381

lildude opened this issue May 5, 2024 · 2 comments

Comments

@lildude
Copy link
Contributor

lildude commented May 5, 2024

Important Notice

The issue tracker is ONLY used for reporting bugs. New features should be discussed in our Slack community or in Discussions.

Incomplete or non-reproducible issues may be closed, but we are here to help! If you encounter difficulties reproducing the bug or need assistance, please reach out to our community channels mentioned above.

Thank you for your understanding and cooperation!

Bug Description

Each interest entry for an account creates a new "symbol" which results in a very full and cluttered "Market data" page.

To Reproduce

  1. Add two interest activities to an account
  2. Browse to Admin control -> Market Data
  3. Note there are two entries. Click each and note the different "symbols".

Expected behavior

Interest really shouldn't get a symbol but if it must because of design decisions, the same "symbol" should be used per account, as is the case for a normal stock.

Maybe interest shouldn't be on the market data page at all?

Screenshots

Image

Image

Image

Logs

N/A

Environment

  • Ghostfolio Version 2.78
  • Self-hosted
  • Experimental Features enabled or disabled - none
  • Firefox
  • macos

Additional context

@dtslvr
Copy link
Member

dtslvr commented May 12, 2024

Interest really shouldn't get a symbol but if it must because of design decisions, the same "symbol" should be used per account, as is the case for a normal stock.

Yes, each activity (Order) is associated to an asset profile (SymbolProfile), therefore reusing the asset profile per account could be cleaner. Would you like to work on that, @lildude?

@dtslvr dtslvr changed the title [BUG] Each interest entry creates a new "symbol" [BUG] Each interest activity creates a new assest profile May 12, 2024
@dickwolff
Copy link
Contributor

dickwolff commented May 21, 2024

@dtslvr I may have a repro on this, or at least an issue that is related.

When importing multiple interests, randomly it generates a new symbol for interest.

I have this input (taken from the import file):

{
    "accountId": "8996c276-de46-4fed-8f2d-9270681dbd49",
    "comment": "Interest on cash",
    "fee": 0.06,
    "quantity": 1,
    "type": "INTEREST",
    "unitPrice": 0.06,
    "currency": "EUR",
    "dataSource": "MANUAL",
    "date": "2024-05-11T21:02:44+02:00",
    "symbol": "Interest on cash"
},
{
    "accountId": "8996c276-de46-4fed-8f2d-9270681dbd49",
    "comment": "Interest on cash",
    "fee": 0.05,
    "quantity": 1,
    "type": "INTEREST",
    "unitPrice": 0.05,
    "currency": "EUR",
    "dataSource": "MANUAL",
    "date": "2024-05-12T21:02:49+02:00",
    "symbol": "Interest on cash"
},

When I import this multiple times, I get the following result. For some reason, the May 12th gets a correct name ("Interest on cash"), but the ones from May 11th gets a guid. Keeps happening to the May 11th, after importing multiple times.

image

Any idea how this happens, and how to prevent it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants