Feat: Extended market data with preset by activitiesCount and date #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @bikash-789. I will review as soon as possible. |
2 tasks
dtslvr
requested changes
Feb 20, 2024
There was a problem hiding this comment.
I have tested the code, but it does not seem to work.
activityCount is always 0. It does not count the number of orders per currency (part of SymbolProfile).
date is undefined, therefore earliestDate is always the current date.
Would you like to give it another try?
@bikash-789 Maybe a good starting point would be importing these activities and manually adding additional currencies (e.g. |
|
@dtslvr Thanks for the suggestion. I will work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3006
I've added attributes
activitesCountanddate(First Activity) on the market data withpresetId=CURRENCIESas you can see in the screenshot. Let me know if I need to make any changes.