Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there interest in ggml_upscale_to_shape supporting non integer scaling factors? #812

Closed
balisujohn opened this issue May 4, 2024 · 0 comments

Comments

@balisujohn
Copy link
Contributor

balisujohn commented May 4, 2024

So I have a tensor code_emb shaped [43,1024], and I need to upscale it to be [187, 1024], to match the torch code. (dimensions listed here left to right ggml style)

expanded_code_emb = F.interpolate(code_emb, size=187, mode='nearest')

Best I can tell, the ggml_upscale only allows integer scaling factors. A clean way to implement this could be to create another op
ggml_upscale_to_shape which upscales a tensor optionally across all 4 dimensions.

Would there be interest in up-streaming this if I work on it?

@balisujohn balisujohn changed the title Is there interest in ggml_upscale_to_size supporting non integer scaling factors? Is there interest in ggml_upscale_to_shape supporting non integer scaling factors? May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant