wgpu-core contains deadlocks
#5572
Assignees
Comments
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this issue
Apr 20, 2024
If `debug_assertions` or the `"validate-locks"` feature are enabled, change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that checks for potential deadlocks. At the moment, `wgpu-core` does contain deadlocks, so the ranking in the `lock::rank` module is incomplete, in the interests of keeping it acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this issue
Apr 20, 2024
If `debug_assertions` or the `"validate-locks"` feature are enabled, change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that checks for potential deadlocks. At the moment, `wgpu-core` does contain deadlocks, so the ranking in the `lock::rank` module is incomplete, in the interests of keeping it acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this issue
Apr 21, 2024
If `debug_assertions` or the `"validate-locks"` feature are enabled, change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that checks for potential deadlocks. At the moment, `wgpu-core` does contain deadlocks, so the ranking in the `lock::rank` module is incomplete, in the interests of keeping it acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this issue
Apr 22, 2024
If `debug_assertions` or the `"validate-locks"` feature are enabled, change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that checks for potential deadlocks. At the moment, `wgpu-core` does contain deadlocks, so the ranking in the `lock::rank` module is incomplete, in the interests of keeping it acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this issue
Apr 22, 2024
If `debug_assertions` or the `"validate-locks"` feature are enabled, change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that checks for potential deadlocks. At the moment, `wgpu-core` does contain deadlocks, so the ranking in the `lock::rank` module is incomplete, in the interests of keeping it acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this issue
Apr 22, 2024
If `debug_assertions` or the `"validate-locks"` feature are enabled, change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that checks for potential deadlocks. At the moment, `wgpu-core` does contain deadlocks, so the ranking in the `lock::rank` module is incomplete, in the interests of keeping it acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this issue
Apr 22, 2024
If `debug_assertions` or the `"validate-locks"` feature are enabled, change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that checks for potential deadlocks. At the moment, `wgpu-core` does contain deadlocks, so the ranking in the `lock::rank` module is incomplete, in the interests of keeping it acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy
added a commit
to jimblandy/wgpu
that referenced
this issue
Apr 22, 2024
If `debug_assertions` or the `"validate-locks"` feature are enabled, change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that checks for potential deadlocks. At the moment, `wgpu-core` does contain deadlocks, so the ranking in the `lock::rank` module is incomplete, in the interests of keeping it acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy
added a commit
that referenced
this issue
Apr 23, 2024
If `debug_assertions` or the `"validate-locks"` feature are enabled, change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that checks for potential deadlocks. At the moment, `wgpu-core` does contain deadlocks, so the ranking in the `lock::rank` module is incomplete, in the interests of keeping it acyclic. #5572 tracks the work needed to complete the ranking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the process of developing #5539, we identified at least one deadlock in
wgpu-core, and I suspect there are others. We should fix these deadlocks, updatinglock::rankas we go, and enable thelock::rankedrun-time validation by default in debug builds.The presence of deadlocks means that no cycle-free ranking of locks exists that won't cause panics in our current tests and examples. This means that the ranking defined in
lock::rankmust either remain incomplete, or we should change the implementation to permit ranking cycles for the time being. The latter option is unappealing, so we plan to land #5539 with an incomplete ranking, meaning that enabling thevalidate-locksfeature will cause panics for now.Issues for specific deadlocks:
poll_all_devicesandqueue_submit#5695Device::temp_suspectedandCommandBuffer::data#5647The text was updated successfully, but these errors were encountered: