Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash compiling and using HLSL shaders #5571

Closed
JMS55 opened this issue Apr 20, 2024 · 2 comments
Closed

Crash compiling and using HLSL shaders #5571

JMS55 opened this issue Apr 20, 2024 · 2 comments
Labels
api: dx12 Issues with DX12 or DXGI area: correctness We're behaving incorrectly area: naga back-end Outputs of naga shader conversion lang: HLSL D3D Shading Language naga Shader Translator type: bug Something isn't working

Comments

@JMS55
Copy link
Contributor

JMS55 commented Apr 20, 2024 •
edited

Source shader: https://paste.rs/CAVpW.txt
Output HLSL and crash: https://paste.rs/nW7t8.txt

Source shader: https://paste.rs/13TBc.txt
Output HLSL and crash: https://paste.rs/A2Vhb.txt
@JMS55 JMS55 changed the title Crash compiling and using HLSL shader Crash compiling and using HLSL shaders Apr 20, 2024
@cwfitzgerald
Copy link
Member

Yeah we need to wrap scalar push constants in structs in the hlsl backend.

@cwfitzgerald cwfitzgerald added type: bug Something isn't working area: correctness We're behaving incorrectly api: dx12 Issues with DX12 or DXGI area: naga back-end Outputs of naga shader conversion naga Shader Translator lang: HLSL D3D Shading Language labels Apr 21, 2024
@JMS55 JMS55 mentioned this issue May 1, 2024
Open
@cwfitzgerald
Copy link
Member

Closing in favor of #5683

@cwfitzgerald cwfitzgerald closed this as not planned Won't fix, can't repro, duplicate, stale May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: dx12 Issues with DX12 or DXGI area: correctness We're behaving incorrectly area: naga back-end Outputs of naga shader conversion lang: HLSL D3D Shading Language naga Shader Translator type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwfitzgerald @JMS55