-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excluded Exceptions list does not play nice with Puma Auto Reload mechanism - dev environment issue #2227
Comments
hmm @st0012 do you have an opinion here? |
I think he means the Rails autoloader, not the puma autoloader. |
I can't reproduce the issue: # config/initializers/sentry.rb
class FooException < StandardError
end
Sentry.init do |config|
# ....
config.excluded_exceptions += ['FooException']
config.logger = Logger.new($stdout)
config.logger.level = :debug
end And in the Here's the logs for 2 requests:
I also don't think reloading the same class will make Can you provide a more detailed example so we can investigate this further? Thank you 😄 |
Issue Description
https://github.com/getsentry/sentry-ruby/blob/master/sentry-ruby/lib/sentry/configuration.rb#L595-L600
This comparison function returns false as soon as the puma server is auto reloaded - (when you change a file in your dev environment) because the reloaded class id will be different
Instead of using
===
. we should probably compare the NAME of the exceptionReproduction Steps
--enable debugging logger
notice that the exception is ignored
User excluded error: XXXXX
Expected Behavior
exceptions are ALWAYS excluded
Actual Behavior
after hot reload exceptions are sent to sentry
Ruby Version
3.2.2
SDK Version
5.15
Integration and Its Version
No response
Sentry Config
No response
The text was updated successfully, but these errors were encountered: