Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replay] Add ui.tap breadcrumbs for Android #3818

Open
krystofwoldrich opened this issue May 14, 2024 · 0 comments
Open

[Replay] Add ui.tap breadcrumbs for Android #3818

krystofwoldrich opened this issue May 14, 2024 · 0 comments

Comments

@krystofwoldrich
Copy link
Member

Description

The RN SDK captures touch breadcrumbs. These are unknown to Sentry Replay player and needs to be converted to ui.tap.

Breadcrumbs conversion was added for sentry-android in https://github.com/getsentry/sentry-java/pull/3406/files#diff-2f6abcfaf76542e5e58a9fbd4458b23ca658763d9bc0f989abfdeeee5c5898ddR205

Extend sentry-android Replay Breadcrumbs conversion so hybrid SDKs like RN can change the conversion, add new conversion, overwrite existing conversion and remove breadcrumb. For ui.tab only adding new conversion is needed, but other types of breadcrumbs, navigation will require overwrite and remove.

The conversion from touch to ui.tap might be implemented for example like this.

breadcrumb.category == "touch" -> {
    breadcrumbCategory = "ui.tap"
    breadcrumbMessage = (breadcrumb.data["componentTree"] as ArrayList<*>).take(3).reversed().joinToString(" > ")
}

The RN SDK Android Replay is implemented in https://github.com/getsentry/sentry-react-native/pull/3714/files#diff-d6a452754193c856062829091f3c2012c9db45999fed9a4bddddf3850ea9dfb0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants