Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix request handler build could be a function #12082

Open
3 tasks done
topaxi opened this issue May 16, 2024 · 1 comment · May be fixed by #12110
Open
3 tasks done

Remix request handler build could be a function #12082

topaxi opened this issue May 16, 2024 · 1 comment · May be fixed by #12110

Comments

@topaxi
Copy link

topaxi commented May 16, 2024

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/remix

SDK Version

8.x

Framework Version

Remix 2

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

createRequestHandler({
  build // is typed as: ServerBuild | (() => Promise<ServerBuild>)
})

See:

https://github.com/remix-run/remix/blob/2e65318b15df407b31b101362e03729e61ec5622/packages/remix-express/server.ts#L40

But Sentry is always assuming that it is an object:

const wrappedEntry = { ...build.entry, module: { ...build.entry.module } };

Expected Result

Sentry should honor upstream interfaces

Actual Result

Sentry does not honor upstream interfaces

@onurtemizkan
Copy link
Collaborator

Thanks for reporting this @topaxi.

A fix for this is going to be part of an extensive update on Remix SDK soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants