-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis span ops marked as 'db' instead of 'cache' #12058
Comments
Hello, thanks for writing! We are indeed working on a feature which let's you define specific prefixes for your cache keys. The API will possibly look something like this: If the key is prefixed with one of the defined prefixes, the ops will be marked as |
Hi @s1gr1d! Is there any way for me to also only have certain commands instrumented? Eg let's say I only care for |
Currently, there isn't. Would you want to specify certain Redis commands to be instrumented in general or just when you're using Redis as a cache? Meaning, Redis would be instrumented for all commands but only when a key is prefixed with e.g. |
If you want, you can already try adding cache prefixes to the integration with the latest version of Sentry. Currently they pick up |
We use Redis for a couple different things, eg sometimes we use
I'm not sure what this means - if I set Since |
So |
I see, so what this sounds like to me is that anything I specify as So even if I set cache prefixes, it probably won't resolve that issue? |
It looks like the docs on cache prefixes are describing an entirely different usage. The docs are saying the cache prefixes array is used for filtering what the cache key itself is prefixed by, rather than the span op of the cache span? |
@rahul-kumar-saini So in general the docs you are referring to are our "develop" docs which are not really intended for end-user consumption but rather for SDK maintainers, so take everything in there with a grain of salt because it is often idealistic and the reality looks different.
The docs here say that if you have a cache invocation, and the cache key matches one of the prefixes, its The caches view will launch soon and we are just in the process of building redis integrations. They are still very much experimental. cc @AbhiPrasad because he is looking at this soon |
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/node
SDK Version
8.0.0
Framework Version
Node v18.18.2
Link to Sentry event
No response
SDK Setup
No response
Steps to Reproduce
Just initialize Sentry and use
ioredis
and run some Redis commands.Expected Result
Redis span ops being
cache
orcache.[get|set|del]
or something.Actual Result
Redis spans marked as
db
, which in turn populates the SQL Queries view with Redis commands and makes it less useful. Would be cool to have a dedicated Cache usage view similar to the Queries view where Redis commands could be aggregated instead.The text was updated successfully, but these errors were encountered: