-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't detect docker even though its installed and in PATH #3025
Comments
What I actually had done was this:
# Assuming current latest version is 24.1.0
# Current actual version can be acquired from the Releases page on GitHub
VERSION="24.4.2"
git clone https://github.com/getsentry/self-hosted.git
(
cd self-hosted || exit 1
git checkout "${VERSION}"
sudo ./install.sh
) sh ./sentry-install.sh By happenstance while debugging I manually went into
and still going So this issue is probably related to trying to using Possible SolutionThis should probably instead checking that the current user has permissions to docker rather than trying to elevate permissions prematurely: if ! groups | grep -q docker; then
echo "$(id -u -n) is not a member of the group 'docker'"
echo "Possible solutions:"
echo " sudo useradd '$(id -u -n)' 'docker' ; bash ./install.sh"
echo "Or"
echo " sudo bash ./install.sh"
fi |
Good solution. I think we'd welcome a PR to this effect if you'd be so inclined! |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Update: Possible Solutions
Rather than instructing the user to use
sudo
prematurely, the install script could detect whether or not the current user has permissions to thedocker
group, or ask the user if they really want tosudo
:Or
In either case, if
sudo
is selectively used only for things that needsudo
, it is less likely to cause permission or environment-related issues.Self-Hosted Version
24.4.2
CPU Architecture
x86_64
Docker Version
25.0.5
Docker Compose Version
2.26.1
Steps to Reproduce
command -v docker
Expected Result
Should detect docker from the current
PATH
.Actual Result
Used something other than
PATH
.Event ID
No response
The text was updated successfully, but these errors were encountered: