Upgrade Clickhouse to 23.8

[hubertdeng123]

Prod is being upgraded, so we should also do this for self-hosted users.

Looks like 21.8 -> 22.8 -> 23.3 -> 23.8

Although, perhaps it is possible to go from 22.8 -> 23.8 because self-hosted upgrades will always incur downtime.

https://docs.altinity.com/releasenotes/altinity-stable-release-notes/23.8/#major-changes-that-require-attention

We should also look to automate this process or make it easier for devs to verify clickhouse upgrades for self-hosted.

[williamdes]

By coincidence I upgraded to 23.8.8.21.altinitystable

apt install clickhouse-server=22.8.20.12.altinitystable clickhouse-common-static=22.8.20.12.altinitystable
apt install clickhouse-server=23.8.8.21.altinitystable clickhouse-common-static=23.8.8.21.altinitystable

But

self-hosted/clickhouse/config.xml

Lines 3 to 6 in f84bb3d

	<!-- This include is important!
	It is required for the version of Clickhouse
	used on ARM to read the environment variable. -->
	<include from_env="MAX_MEMORY_USAGE_RATIO"/>

Will break Clickhouse. You need to use (default value for example)

<max_server_memory_usage_to_ram_ratio>0.9</max_server_memory_usage_to_ram_ratio>

[hubertdeng123]

@williamdes I was able to get past the error by removing the newlines 🤔

[williamdes]

@williamdes I was able to get past the error by removing the newlines 🤔

Okay, well I did not want to fight more as it was a nightmare finding this block. Great that the env can be kept as is

[dlouzan]

We run a self-hosted setup in which we cannot rely on the provided scripts for migrations, so we need to rewrite them for our configuration, and while migrating to 24.5.0 I was just confronted with this issue, it definitely didn't cross my mind that breaking the xml into multiple lines for readibility would kill clickhouse 😅

Perhaps a short comment on

self-hosted/clickhouse/config.xml

Line 3 in 6032d98

<max_server_memory_usage_to_ram_ratio><include from_env="MAX_MEMORY_USAGE_RATIO"/></max_server_memory_usage_to_ram_ratio>

referencing the upstream issue will help others in the future.

[hubertdeng123]

@dlouzan I've added this in #3085. Closing this issue as this has been completed