Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept DSC as item header #3461

Open
Tracked by #3537
jjbayer opened this issue Apr 19, 2024 · 0 comments
Open
Tracked by #3537

Accept DSC as item header #3461

jjbayer opened this issue Apr 19, 2024 · 0 comments

Comments

@jjbayer
Copy link
Member

jjbayer commented Apr 19, 2024

Trace-based sampling decisions take their input from the "trace" envelope header a.k.a. DynamicSamplingContext.

One of the DSC fields in "transaction". For span streaming, SDKs might send multiple spans with different segment names. In order to apply consistent sampling we need to either

  1. Force SDKs to put spans with different DSCs into different envelopes.
  2. Start accepting DSCs as item headers, and use it in the sampling decision (with fallback to envelope header). Because each item's DSC might have a different root project aka trace project aka sampling state, we would need to split up the envelope by root project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant