Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid relay config should fail integration tests #3429

Open
iker-barriocanal opened this issue Apr 15, 2024 · 0 comments
Open

Invalid relay config should fail integration tests #3429

iker-barriocanal opened this issue Apr 15, 2024 · 0 comments
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date

Comments

@iker-barriocanal
Copy link
Member

iker-barriocanal commented Apr 15, 2024 •
edited

The fixture system uses some default values for Relay's static configuration that hide broken configs. This should not be the case, and tests should fail instead. See latest example.

Specifically:
The fixture has a default processing config. I added a config that was invalid because the required processing config didn't exist, but the tests passed due to the defaults. I'd expect the test to fail in such case.
@iker-barriocanal iker-barriocanal mentioned this issue Apr 15, 2024
Merged
@olksdr olksdr added filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olksdr @iker-barriocanal