-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INC-696] Validate Kafka configuration on startup #3404
Comments
This is possible but breaks with a cluster that relies on topics to be auto created, which is the default setting. Probably an issue for self hosted and our own tests also rely on this behaviour. |
Self hosted doesn't rely on topic auto-creation (it uses snuba bootstrap + https://github.com/getsentry/self-hosted/blob/67382fd2abc0357e6d39634c4051cae0240da9c2/install/create-kafka-topics.sh for the rest IIRC) |
Ah okay, I saw the list and though it was a bit short, if the rest is created elsewhere that's good to know. Our current plan would be to have config flag which toggles a strict mode in which Relay validates topics, question is whether it should be on by default. |
When Relay is configured to publish to a non-existing topic, it currently starts normally and only starts logging errors when traffic for that topic comes in.
Relay should fail startup when a Kafka topic does not exist.
Note: This issue is a narrower version of #2766.
The text was updated successfully, but these errors were encountered: