Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the version of craft used for publishing a release #664

Open
rhcarvalho opened this issue Nov 18, 2021 · 1 comment
Open

Comments

@rhcarvalho
Copy link

The publish process always use the latest Craft Docker image (with the latest published version of the craft binary):

- uses: docker://getsentry/craft:latest
name: Publish using Craft

Craft releases themselves are published with this repository workflow. Whenever there's a broken Craft release, all releases, including Craft's, are affected and require manual operator intervention as in #577, where we had to temporarily hard-pin the image version to a known state to unblock releases.

We could make an operator's life easier, and their job safer, by allowing the version to be chosen without requiring temporary patches to the publish workflow.

How exactly that's done is up for debate. Some options:

  • Dropdown in the release issue to choose the version, pre-populated with the last few Craft versions
  • Use the minimum craft version as specified in the .craft.yml config of the target repo
  • Use some "known-to-be-stable" version and bump that periodically

All with pros and cons.

@BYK
Copy link
Contributor

BYK commented Nov 19, 2021

action-prepare-release has implicit support for this already: https://github.com/getsentry/action-prepare-release/blob/fa92eb5b15e20315c39d1da48a502d4f7bc73190/action.yml#L14-L17

You'd need to find a way to incorporate and relay that information through the issue format. I'd say it is definitely not worth the hassle and complexity as you can easily pin/fix the craft version.

A more important issue is publish always using the latest master build of craft whereas action-prepare-release using the latest released version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants